From: Jan Beulich <jbeulich@suse.com>
Date: Wed, 27 Jul 2022 11:00:08 +0000 (+0200)
Subject: x86/PV: correct post-preemption progress recording in iommu_memory_setup()
X-Git-Tag: archive/raspbian/4.17.0-1+rpi1^2~33^2~377
X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https://%22%22/%22http:/www.example.com/cgi/%22https:/%22%22?a=commitdiff_plain;h=f732240fd3bac25116151db5ddeb7203b62e85ce;p=xen.git

x86/PV: correct post-preemption progress recording in iommu_memory_setup()

Coverity validly points out that the mfn_add() as used was dead code.

Coverity ID: 1507475
Fixes: c1e1564c8995 ("IOMMU/x86: perform PV Dom0 mappings in batches")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
---

diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c
index 323c49b0bd..a62f0fa2ef 100644
--- a/xen/arch/x86/pv/dom0_build.c
+++ b/xen/arch/x86/pv/dom0_build.c
@@ -130,7 +130,7 @@ static void __init iommu_memory_setup(struct domain *d, const char *what,
                             IOMMUF_readable | IOMMUF_writable | IOMMUF_preempt,
                             flush_flags)) > 0 )
     {
-        mfn_add(mfn, rc);
+        mfn = mfn_add(mfn, rc);
         nr -= rc;
         /* See comment below. */
         for ( ; rc--; ++page )